-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RecurrencePattern.Count
, .Interval
and WeekDay.Offset
nullable to avoid using MinValue
as magic number.
#667
Conversation
Codecov ReportAttention: Patch coverage is @@ Coverage Diff @@
## main #667 +/- ##
===================================
- Coverage 63% 63% -0%
===================================
Files 99 99
Lines 4592 4594 +2
Branches 1086 1085 -1
===================================
+ Hits 2876 2877 +1
+ Misses 1261 1258 -3
- Partials 455 459 +4
|
@axunonb I had this in the pipeline and as you just did the same for |
… `int.MinValue`.
13c9f2e
to
6576096
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and sorry for interfering re UNTIL
Oh, no worries, I didn't do anything with |
Make the following properties nullable to avoid using
MinValue
as magic number:RecurrencePattern.Count
RecurrencePattern.Interval
WeekDay.Offset
Closes #471